fix: skip metrics submission on fatal generation errors (fixes #2010) - #2127
fix: skip metrics submission on fatal generation errors (fixes #2010)#2127armorbreak001 wants to merge 1 commit into
Conversation
|
…pi#2010) When a command fails with an error, the finally() handler still attempted to submit anonymous usage metrics, which could fail and produce a misleading secondary error message. Skip metrics recording entirely on failure so only the actual error is shown to the user.
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
1 participant
Summary
When a command fails with an error, the
finally()handler still attempted to submit anonymous usage metrics viarecordActionFinished(). This could fail independently (e.g. network error when flushing to NewRelic), producing a misleading secondary error message that obscures the actual cause of failure.Changes
src/apps/cli/internal/base.ts: Infinally(), return early whenerroris set instead of proceeding to record metrics. This ensures only the real error is shown to the user.Reproduction (from issue)
Before: Two errors — the real one plus
Skipping submitting anonymous metrics due to the following error: TypeError: fetch failedAfter: Only the actual generator error is displayed.